-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks against linearmodels
and fastreg
#558
Comments
@rafimikail would you be interested in picking this up? |
Hi @s3alfisc, so this one is basically adding another two lines (linearmodels and fastreg) in our performance benchmarking line plots right? |
Yes, exactly! Maybe best to start with one of the two packages and divide this into two PRs? Is it ok if I assign you @rafimikail? |
Certainly @s3alfisc , you can allocate this to me 👍 |
Hi @s3alfisc , wanted to confirm, to run_benchmarks.ipynb, i think i need to retrieve some data first that will be used in the notebook, do i need to run data_generation.r first before running the notebook or i could just get it from https://github.com/lrberge/fixest/tree/master/_BENCHMARK? Thanks! |
Oh I completely overlooked this - you would have to run the data generation r script first. I can also do so quickly and send you the data as a csv? |
Hey @s3alfisc , i tried to run the data generation r file but experiencing an error, need to find out why But if you have the data/csv already, that would be helpful Thanks |
Will send it in a moment :) |
Context
It would be great to add benchmarks against the following two python packages:
@apoorvalal has benchmarks against
fastreg
here, showing equal performance topyfixest
.To Do
linearmodels
andfastreg
. Forlinearmodels
, add benchmarks for OLS, forfastreg
for OLS and Poisson (linearmodels does not support Poisson afaik).The text was updated successfully, but these errors were encountered: