Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks against linearmodels and fastreg #558

Open
s3alfisc opened this issue Jul 21, 2024 · 8 comments
Open

Add benchmarks against linearmodels and fastreg #558

s3alfisc opened this issue Jul 21, 2024 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@s3alfisc
Copy link
Member

s3alfisc commented Jul 21, 2024

Context

It would be great to add benchmarks against the following two python packages:

@apoorvalal has benchmarks against fastreg here, showing equal performance to pyfixest.

To Do

  • Adjust the pyfixest benchmarks by including benchmarks for linearmodels and fastreg. For linearmodels, add benchmarks for OLS, for fastreg for OLS and Poisson (linearmodels does not support Poisson afaik).
  • Update the benchmark figures by adjusting and running the visualize_benchmarks.ipynb notebook.
@s3alfisc
Copy link
Member Author

@rafimikail would you be interested in picking this up?

@s3alfisc s3alfisc added enhancement New feature or request good first issue Good for newcomers labels Jul 21, 2024
@rafimikail
Copy link
Contributor

Hi @s3alfisc, so this one is basically adding another two lines (linearmodels and fastreg) in our performance benchmarking line plots right?

@s3alfisc
Copy link
Member Author

s3alfisc commented Jul 21, 2024

Yes, exactly! Maybe best to start with one of the two packages and divide this into two PRs? Is it ok if I assign you @rafimikail?

@s3alfisc s3alfisc assigned rafimikail and unassigned rafimikail Jul 21, 2024
@rafimikail
Copy link
Contributor

Certainly @s3alfisc , you can allocate this to me 👍

@rafimikail
Copy link
Contributor

Hi @s3alfisc , wanted to confirm, to run_benchmarks.ipynb, i think i need to retrieve some data first that will be used in the notebook, do i need to run data_generation.r first before running the notebook or i could just get it from https://github.com/lrberge/fixest/tree/master/_BENCHMARK?

Thanks!

@s3alfisc
Copy link
Member Author

Oh I completely overlooked this - you would have to run the data generation r script first. I can also do so quickly and send you the data as a csv?

@rafimikail
Copy link
Contributor

Hey @s3alfisc , i tried to run the data generation r file but experiencing an error, need to find out why

But if you have the data/csv already, that would be helpful

Thanks

@s3alfisc
Copy link
Member Author

Will send it in a moment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants