Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement math operators for meta tensors #55

Open
brandonwillard opened this issue Jul 24, 2019 · 1 comment
Open

Implement math operators for meta tensors #55

brandonwillard opened this issue Jul 24, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brandonwillard
Copy link
Contributor

As a convenience, we should provide meta tensor implementations of the following:
__add__, __radd__, __sub__, __rsub__, __mul__, __rmul__, __div__, __rdiv__, __truediv__, __rtruediv__, __floordiv__, __rfloordiv__, __mod__, __rmod__, __lt__, __le__, __gt__, __ge__, __and__, __rand__, __or__, __ror__, __xor__, __rxor__, __getitem__, __pow__, __rpow__, __invert__, __neg__, __abs__, __matmul__, __rmatmul__.

Looks like some of these are specified for tf.Tensor in tensorflow.python.ops.math_ops.
@brandonwillard brandonwillard added enhancement New feature or request good first issue Good for newcomers labels Jul 24, 2019
@brandonwillard brandonwillard mentioned this issue Oct 24, 2019
Merged
@brandonwillard
Copy link
Contributor Author

The most basic algebraic operators (e.g. __[r]add__, __[r]sub__, etc.) have been added to the TensorFlow meta tensor class in #79. The same needs to be done for Theano, along with the other, non-algebraic operators in TensorFlow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandonwillard