-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide sample code for a very basic client #17
Comments
Thanks - although I'm slightly confused as none of that code seems to import this project. So I'm not entirely sure how it relates to what I asked about? |
Sorry, I should have linked directly to the lines in question. Right now the library only provides two things, entry point script generation and record parsing (+ validation with my PR). It is pretty minimal, but the usage is shown in that code. #16 will implement the actual install functionality. |
Ah, sorry. I did skim for local imports, but missed these. I'm still a great fan of having a bare-bones usage in an |
I agree 😄. |
As noted in #1, the plan is to provide basic implementations of the abstractions, which can actually be used by end users. They'll be importable (instead of sitting in Right now, my plan is (1) WheelSource from a local .whl file and (2) Destination based on a dictionary of a |
Closing, since this is now provided in the documentation, hosted at https://installer.readthedocs.io/en/latest/. (yes, there's a misnamed object in the example; I've fixed that as part of writing the rest of the documentation) |
I'm finding it hard to understand how the library would be used in practice. In the longer term, this will be covered by the documentation. But for early adopters, having an example of the intended use would be really helpful.
Could an
examples
directory be added with a very basic client that takes a wheel file and extracts it? I'd go for:sysconfig
or anything that hides the question of "what locations do I need to support" behind what a given Python installation provides).Including notes about what isn't supported, compared to something like pip (hash checking? script wrappers?) with a brief note describing how clients would typically implement these, would give a much better feel for the scope of the library, as well.
(My personal concern here is that writing script wrappers is out of scope, but it will be hard for clients to implement without assistance to identify what scripts need writing. I'd like to have sample code that offers a concrete example of how that would play out in reality).
The text was updated successfully, but these errors were encountered: