Fix KeyError in _HandleCoaPacket for 0.0.0.0 host #196
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When defining a client host `0.0.0.0` for a CoA radius Server, then a
KeyError will occur when handling a CoA packet.
File ".../pyrad/server.py", line 250, in _HandleCoaPacket
pkt.secret = self.hosts[pkt.source[0]].secret
~~~~~~~~~~^^^^^^^^^^^^^^^
KeyError: '172.16.0.100'
The reason seems to be that _AddSecret() was added at some point to
support using `0.0.0.0` as a host, but the `pkt.secret = ...` assignment
that it ought to replace was not removed.
This patch fixes the behavior by removing the stale assignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When defining a client host
0.0.0.0for a CoA radius Server, then a KeyError will occur when handling a CoA packet.The reason seems to be that _AddSecret() was added at some point to support using
0.0.0.0as a host, but thepkt.secret = ...assignment that it ought to replace was not removed.This patch fixes the behavior by removing the stale assignment.