Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused patches #1

Open
marcogario opened this issue Jul 23, 2015 · 3 comments
Open

Remove unused patches #1

marcogario opened this issue Jul 23, 2015 · 3 comments
Assignees
@mikand

Comments

@marcogario
Copy link
Contributor

The patch for pycudd and picosat do not apply anymore.

We should remove them, in order to keep only what still needs to be integrated. This way we can easily plan to move the patches upstream.
@mikand
Copy link
Contributor

mikand commented Jul 24, 2015

Done, but picosat patch IS used right now, Z3 is the one is not used anymore. 😄

@mikand mikand closed this as completed Jul 24, 2015
@marcogario
Copy link
Contributor Author

Isn't the patch for picosat already in the dedicated repo? https://github.com/pysmt/pyPicoSAT

If not, I think that is where it should be.

@marcogario marcogario reopened this Jul 24, 2015
@mikand
Copy link
Contributor

mikand commented Jul 24, 2015

That repo is currently unused by the install.py script. Eventually it will be, but for the moment this repo is used to patch picosat instead...

https://github.com/pysmt/pysmt/blob/7a9ed4b5ac19b6b0a5f916521dcfa4268870d900/pysmt/cmd/install.py#L398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikand mikand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcogario @mikand