Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstring-to-markdown as optional dependency #537

Open
npradeep357 opened this issue Mar 19, 2024 · 3 comments
Open

docstring-to-markdown as optional dependency #537

npradeep357 opened this issue Mar 19, 2024 · 3 comments

Comments

@npradeep357
Copy link
Contributor

Hi ,I'm using python-lsp-server as part of our custom IDE and in our case we don't need the docstring-to-markdown for the following reasons:

  • we have our own custom converter which does it for us.
  • 'docstring-to-markdown' comes with LGPL license.

Any thoughts on this are welcome. Thank you.

@ccordoba12
Copy link
Member

@krassowski, what do you think about this one?

@krassowski
Copy link
Contributor

krassowski commented Mar 24, 2024

'docstring-to-markdown' comes with LGPL license

Please note the "L" in front. It means you can license your own code which uses docstring-to-markdown any way you like 🤷 I find a lot of people confuse GPL with LGPL.

we have our own custom converter which does it for us.

I think the docstring-to-markdown provides a good user experience and should be included by default so it should not be optional in the sense of moving it to extras (i.e. not require installation with python-lsp-server[all] but be installed with just python-lsp-server). However, it would be reasonable to have an entry point that allows to swap docstring-to-markdown to a preferred docstring converter of choice (including a converter that does nothing).

@ccordoba12
Copy link
Member

I think the docstring-to-markdown provides a good user experience and should be included by default so it should not be optional in the sense of moving it to extras (i.e. not require installation with python-lsp-server[all] but be installed with just python-lsp-server).

Agreed.

However, it would be reasonable to have an entry point that allows to swap docstring-to-markdown to a preferred docstring converter of choice (including a converter that does nothing).

I agree with this too. @npradeep357, up to you if you want to submit a PR to implement that because it won't offer any benefit to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants