Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation correction after dictionary indexing (and PC correction) before refinement #454

Open
hakonanes opened this issue Oct 11, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@hakonanes
Copy link
Member

We should provide dynamic orientation and projection center corrections following the procedure in Singh et al. (2017). Python versions were implemented by @friedkitteh in his thesis. I think both corrections can be available as separate methods to the EBSDDetector.

@hakonanes hakonanes added the enhancement New feature or request label Oct 11, 2021
@hakonanes
Copy link
Member Author

hakonanes commented Nov 2, 2021

Duplicate of #352:

We should add a projection/pattern center (PC) calculation method to kikuchipy.detectors.EBSDDetector which populates a map of navigation shape with PCs from the geometrical relations in Eqs. (8) and (9) in Appendix A in Singh et al. (2017).

This could then be used as a first approximation of PCs per point, instead of a constant PC, in orientation and/or PC refinement following dictionary indexing, given that the detector pixel size and navigation step size in both directons are known.

@hakonanes
Copy link
Member Author

@hakonanes
Copy link
Member Author

Extrapolation of a mean PC to a map of PCs was added in #587 with a tutorial added in #588. The update to orientations given an update in the PC remains to be added.

@hakonanes hakonanes changed the title Orientation and PC correction after dictionary indexing before refinement Orientation correction after dictionary indexing (and PC correction) before refinement Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant