Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inherited methods in the Miller class #367

Open
hakonanes opened this issue Jun 17, 2022 · 0 comments
Open

Fix inherited methods in the Miller class #367

hakonanes opened this issue Jun 17, 2022 · 0 comments

Comments

@hakonanes
Copy link
Member

The Miller class inherits methods and properties from Vector3d and thus also Object3d. Currently, these methods and properties aren't handled properly:

Vector3d

  • empty()
  • from_polar()
  • get_circle()
  • get_nearest() (should raise NotImplementedError)
  • rotate()
  • xvector()
  • yvector()
  • zero()
  • zvector()
  • perpendicular

Object3d

  • get_random_sample()
  • squeeze()
  • stack()

It's not critical to get this in as a patch release, releasing it in 0.10 is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant