Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotting parameter direction should allow an array-like of three numbers #369

Open
hakonanes opened this issue Jul 26, 2022 · 1 comment
Open

Plotting parameter direction should allow an array-like of three numbers #369

hakonanes opened this issue Jul 26, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@hakonanes
Copy link
Member

Currently, many functions taking in a direction parameter, which defines a sample or crystal direction, requires a Vector3d when set. We should really allow a list, tuple or NumPy array or three numbers as well. An example is Orientation.scatter("ipf", direction=(0, 0, 1)), which is not possible, we have to pass a Vector3d to direction.
@hakonanes hakonanes added the enhancement New feature or request label Jul 26, 2022
@hakonanes hakonanes added this to the v0.10.0 milestone Jul 26, 2022
@hakonanes hakonanes removed this from the v0.10.0 milestone Aug 24, 2022
@hakonanes
Copy link
Member Author

This should be restricted to cases where direction signifies a sample direction, and not a crystal direction in which case we need a Miller instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hakonanes