Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid caching presto worker nodes #462

Open
JamesRTaylor opened this issue Oct 1, 2020 · 2 comments
Open

Avoid caching presto worker nodes #462

JamesRTaylor opened this issue Oct 1, 2020 · 2 comments

Comments

@JamesRTaylor
Copy link
Contributor

After a presto worker nodes gets deregistered from the coordinator. because it is no longer responsive, we've noticed that it still receives cache requests to be read from for a period of time. This can lead to internal errors for the query and/or slower response times. Instead, since the rubix presto cluster manager has a handle to the presto node manager, it can get the worker nodes directly from it, sorting and adjusting the node index only when the nodes have changed.

@JamesRTaylor
Copy link
Contributor Author

@stagraqubole - I can take this one if you'd like.

@shubhamtagra
Copy link

Sure @JamesRTaylor

JamesRTaylor pushed a commit to JamesRTaylor/rubix that referenced this issue Oct 6, 2020
JamesRTaylor pushed a commit to JamesRTaylor/rubix that referenced this issue Oct 7, 2020
@JamesRTaylor JamesRTaylor changed the title Avoid caching presto worker worker nodes Avoid caching presto worker nodes Nov 4, 2020
JamesRTaylor pushed a commit to JamesRTaylor/rubix that referenced this issue Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants