From 4ebb88cceddeafa5cf34651d9d2838a5eac09159 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 24 Nov 2022 19:18:03 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- ttslearn/pretrained/__init__.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/ttslearn/pretrained/__init__.py b/ttslearn/pretrained/__init__.py index cd34d80..b96977f 100644 --- a/ttslearn/pretrained/__init__.py +++ b/ttslearn/pretrained/__init__.py @@ -190,7 +190,26 @@ def retrieve_pretrained_model(name): urlretrieve(url, filename, reporthook=t.update_to) t.total = t.n with tarfile.open(filename, mode="r|gz") as f: - f.extractall(path=CACHE_DIR) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, path=CACHE_DIR) os.remove(filename) return out_dir