From 12418ebffee4dd9778d84b7d63a664328fea57f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Harabie=C5=84?= Date: Fri, 14 Oct 2022 19:45:59 +0200 Subject: [PATCH] Fix clippy warnings --- src/dir.rs | 1 + src/file.rs | 2 +- src/fs.rs | 1 + src/table.rs | 2 +- 4 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/dir.rs b/src/dir.rs index 4b7e58c..4f48583 100644 --- a/src/dir.rs +++ b/src/dir.rs @@ -117,6 +117,7 @@ impl<'a, IO: ReadWriteSeek, TP, OCC> Dir<'a, IO, TP, OCC> { /// Creates directory entries iterator. #[must_use] + #[allow(clippy::iter_not_returning_iterator)] pub fn iter(&self) -> DirIter<'a, IO, TP, OCC> { DirIter::new(self.stream.clone(), self.fs, true) } diff --git a/src/file.rs b/src/file.rs index 3675d56..2a2042f 100644 --- a/src/file.rs +++ b/src/file.rs @@ -110,7 +110,7 @@ impl<'a, IO: ReadWriteSeek, TP, OCC> File<'a, IO, TP, OCC> { bytes_left -= size; Ok(Extent { offset: fs.offset_from_cluster(cluster), - size: size, + size, }) }, Err(e) => Err(e), diff --git a/src/fs.rs b/src/fs.rs index 6f81d73..996a68d 100644 --- a/src/fs.rs +++ b/src/fs.rs @@ -256,6 +256,7 @@ impl FsOptions { impl FsOptions { /// If enabled accessed date field in directory entry is updated when reading or writing a file. + #[must_use] pub fn update_accessed_date(mut self, enabled: bool) -> Self { self.update_accessed_date = enabled; self diff --git a/src/table.rs b/src/table.rs index bfeb9ba..3afbb63 100644 --- a/src/table.rs +++ b/src/table.rs @@ -519,7 +519,7 @@ impl FatTrait for Fat32 { { let old_reserved_bits = Self::get_raw(fat, cluster)? & 0xF000_0000; - if value == FatValue::Free && cluster >= 0x0FFF_FFF7 && cluster <= 0x0FFF_FFFF { + if value == FatValue::Free && (0x0FFF_FFF7..=0x0FFF_FFFF).contains(&cluster) { // NOTE: it is technically allowed for them to store FAT chain loops, // or even have them all store value '4' as their next cluster. // Some believe only FatValue::Bad should be allowed for this edge case.