Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .lead & .stat to style drop down on WYSIWYG #40

Open
mtrythall opened this issue Apr 4, 2018 · 8 comments
Open

Add .lead & .stat to style drop down on WYSIWYG #40

mtrythall opened this issue Apr 4, 2018 · 8 comments
Labels
enhancement New feature or request

Comments

@mtrythall
Copy link
Collaborator

We need a way to apply the lead style to the WYSIWYG.

@mtrythall mtrythall added the enhancement New feature or request label Apr 4, 2018
@mtrythall mtrythall self-assigned this Apr 4, 2018
@mtrythall mtrythall changed the title Add .lead to style drop down on WYSIWYG Add .lead & .stat to style drop down on WYSIWYG Apr 11, 2018
@mtrythall
Copy link
Collaborator Author

Maybe @sodevious can help with this one.

We need to add these classes to the style drop down on CKEditor:

https://docs.ckeditor.com/ckeditor4/latest/guide/dev_howtos_styles.html#how-do-i-customize-the-styles-drop-down-list

We can use this file:

https://github.com/rapidpro/chpro-microsite/blob/custom-ckeditor/rh/client/static/admin/extensions.js#L19-L26 (note this is in the custom-ckeditor branch).

Unfortunately, it doesn't immediately work.

@mtrythall mtrythall assigned sodevious and unassigned mtrythall and sodevious Apr 11, 2018
@mtrythall
Copy link
Collaborator Author

Spoke with @nicolaslara about this one and going to try setting this up via base.py.

@mtrythall
Copy link
Collaborator Author

I've since learned that you can't append here, you have to overwrite. So, that's what we'll do.

Could be wrong, but haven't see any other examples.

@sodevious sodevious assigned sodevious and unassigned sodevious Apr 30, 2018
@mtrythall
Copy link
Collaborator Author

We're using django-ckeditor: https://github.com/django-ckeditor/django-ckeditor

@jessiofhall
Copy link

@sodevious and @mtrythall what's happening with this issue? Do we need to complete or add it back to the backlog?

@mtrythall
Copy link
Collaborator Author

Ack, we never got around to it. I don't think it's blocking anyone, it's a nice to have. Basically, there's a drop down in the WYSIWYG editor to apply some common styles. It'd be nice to have that drop down work with our styles (instead of the defaults), but it doesn't currently.

You can still apply the styles via the code editor on the WYSIWYG, but that's not as user friendly.

I still think it'd be great to have, but couldn't figure it out immediately without throwing out a bunch of existing WYSIWYG config.

@jessiofhall
Copy link

Should we move it back to the backlog? Was this a request or something you noticed?

@mtrythall
Copy link
Collaborator Author

Something I noticed/We do on most Django CMS efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants