Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make methods / fields on buffer that deal with the underlying content index private. #1122

Open
joshka opened this issue May 21, 2024 · 0 comments · May be fixed by #1123
Open

Make methods / fields on buffer that deal with the underlying content index private. #1122

joshka opened this issue May 21, 2024 · 0 comments · May be fixed by #1123
Assignees
@joshka
Labels
Status: In Progress Someone is actively working on this Type: Breaking Change This change will cause application code to break and must be noted in the breaking changes docs etc.

Comments

@joshka
Copy link
Member

joshka commented May 21, 2024 •
edited
Loading

I'd prefer to make the content field and the methods that deal directly with indexes (index_of, pos_of) private as it may allow us to migrate to more efficient storage approaches than we currently use. For now, I'd prefer to keep this as an additive only change and do the larger things separately after some discussion.

Originally posted by @joshka in #1084 (comment)
@joshka joshka linked a pull request May 21, 2024 that will close this issue
Draft
@EdJoPaTo EdJoPaTo mentioned this issue May 22, 2024
Merged
@joshka joshka added Status: In Progress Someone is actively working on this Type: Breaking Change This change will cause application code to break and must be noted in the breaking changes docs etc. labels Jun 19, 2024
@joshka joshka self-assigned this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshka joshka

Labels
Status: In Progress Someone is actively working on this Type: Breaking Change This change will cause application code to break and must be noted in the breaking changes docs etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: deprecate Buffer::get and get_mut ratatui-org/ratatui
1 participant
@joshka