Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "get all IPs" function? #2

Open
adam-p opened this issue Apr 14, 2022 · 0 comments
Open

Add "get all IPs" function? #2

adam-p opened this issue Apr 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@adam-p
Copy link
Contributor

adam-p commented Apr 14, 2022

This blog post mentions using all X-Forwarded-For/Forwarded IPs in a "deny if any" access control scheme: disallow if any of the XFF IPs are on a forbidden list. To participate in that scheme, we would need to return all IPs, rather than just one "real" IP.

Is that access controls scheme just hypothetical? Is supporting it outside our purview? Or should we add the functions necessary to enable it?

This wouldn't really be a "strategy". Probably just a function that takes r.Header and returns a slice of strings. Maybe only valid ones? Maybe not?

@adam-p adam-p added the enhancement New feature or request label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant