Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable deprecation warnings #29740

Open
rarkins opened this issue Jun 18, 2024 · 2 comments
Open

Configurable deprecation warnings #29740

rarkins opened this issue Jun 18, 2024 · 2 comments
Labels
core:dashboard Related to Dependency Dashboard functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jun 18, 2024

Describe the proposed change(s).

Add a new option "deprecationWarnings" with enum values:

  • "disabled"
  • "dashboard" (default, what we currently have)
  • "combined-issue" (create a separate issue with all warnings inside instead of embedding in the Dashboard)
  • "issue-per-package" (create one issue per package instead of in the dashboard)

In the case of the issues, the user should be allowed to close the issue to ignore it and it doesn't come back. We should log an info message if it's ignored.

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others core:dashboard Related to Dependency Dashboard functionality labels Jun 18, 2024
@HonkingGoose
Copy link
Collaborator

I see there's a refactor PR that removes old code related to deprecationWarningIssue:

But in this issue you want to have these options:

  • "combined-issue" (create a separate issue with all warnings inside instead of embedding in the Dashboard)
  • "issue-per-package" (create one issue per package instead of in the dashboard)

Do you intend to have new code for these features? I wonder if there's anything worth saving from the "throw out old code PR". 😉

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 19, 2024

Yes, I think it's better to start over - that code is really old, and we can copy/paste if we need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:dashboard Related to Dependency Dashboard functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants