Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pinned presets #29946

Open
HonkingGoose opened this issue Jun 30, 2024 · 1 comment
Open

Support pinned presets #29946

HonkingGoose opened this issue Jun 30, 2024 · 1 comment
Labels
core:config Related to config capabilities and presets priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@HonkingGoose
Copy link
Collaborator

Describe the proposed change(s).

This feature is about supporting pinned presets.

Example

Snippet of a user's configuration:

  "extends": ["local>myproject/renovate-config#1.0.3"]

When the user publishes a new version of their config, Renovate creates a PR to update the preset:

- "extends": ["local>myproject/renovate-config#1.0.3"]
+ "extends": ["local>myproject/renovate-config#1.0.4"]

Context

A user asked if Renovate recommends pinning organizational presets, and @rarkins responded:

I don't think most people would need to do this (pin org presets), because the "noise" it creates (a PR/commit in every repo each time there's a change to the central preset) likely isn't worth it for the "safety" it provides. Also if you set it to automatically merge the upgrades you probably break yourself anyway.

On the other hand, the more pinned your dependencies are (and this is in theory a dependency too), the more reproducible your software is, so I wouldn't call it a bad idea.

This could perhaps be done with a custom regex manager, although "first class" support with its own manager would be nice too.

@rarkins also wanted me to create a new issue for this feature. 😄

Related discussion

This discussion was the starting point of this idea:

@HonkingGoose HonkingGoose added type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:requirements Full requirements are not yet known, so implementation should not be started core:config Related to config capabilities and presets labels Jun 30, 2024
@HonkingGoose
Copy link
Collaborator Author

@rarkins can you explain which solution you want to use for this issue? You mentioned:

  1. Use custom regex manager, or
  2. Write new pinned-presets manager, with first-class support

I've marked this issue as status:requirements because we first need to know the scope of the work. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:config Related to config capabilities and presets priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

1 participant