feat: [sc-103119] URI is not replacing the spec but merging instead

[nvanthao]

Description, Motivation and Context

Fixes: #1486
Fixes: #1537

Demo: https://asciinema.org/a/657334

Checklist

• New and existing tests pass locally with introduced changes.
• Tests for the changes have been added (for bug fixes / features)
• The commit message(s) are informative and highlight any breaking changes
• Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

• Yes
• No

[banjoh]

I believe this ought to be assert.Nil(t, sb.Spec.Collectors[1].ClusterInfo), if replacing the uri into orig in line 118 worked. But it won't work because "$MY_URI" does not exist in your template spec (orig) because it was already templated out by Test_loadSupportBundleSpecsFromURIs test in line 48. var orig is a global variable :(

What you want to do is extract var orig.. into a separate function and use it in your tests like below

func templSpec() string {
	return `
apiVersion: troubleshoot.sh/v1beta2
kind: SupportBundle
metadata:
  name: sb-1
spec:
  uri: $MY_URI
  collectors:
    - configMap:
        name: kube-root-ca.crt
        namespace: default
`
}

Then use it in your tests like so

orig := strings.ReplaceAll(templSpec(), "$MY_URI", srv.URL)

[nvanthao]

many thanks @banjoh! I've updated the tests.