Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is favicon still part of the engine? #248

Open
damianooldoni opened this issue Jul 25, 2023 · 3 comments
Open

Is favicon still part of the engine? #248

damianooldoni opened this issue Jul 25, 2023 · 3 comments
Assignees
@niconoe
Labels
Maybe later

Comments

@damianooldoni
Copy link
Collaborator

damianooldoni commented Jul 25, 2023 •
edited
Loading

I think the favicon should be part of the configuration, not of the engine. If this is already the case, then I think we should replace it. IMO the demo should use the GBIF logo as favicon to underline the link with GBIF. At the moment, the favicon is the LIFE RIPARIAS logo:

image
@niconoe niconoe self-assigned this Jul 26, 2023
@niconoe
Copy link
Member

niconoe commented Jul 26, 2023

You're absolutely right, I forgot about that one!

@damianooldoni damianooldoni added the priority Sept 2023 priority issues for release v2 label Sep 20, 2023
@damianooldoni
Copy link
Collaborator Author

Maybe a easy win? If not, leave it for later and remove the label, please! No pressure.

@niconoe
Copy link
Member

niconoe commented Sep 27, 2023

This is not super easy unfortunately, but I am still hopeful to make time for this issue!

@niconoe niconoe added Maybe later and removed priority Sept 2023 priority issues for release v2 labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niconoe niconoe

Labels
Maybe later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niconoe @damianooldoni