Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for alternative compact model format #25

Open
Zarxrax opened this issue Jul 25, 2022 · 2 comments
Open

Support for alternative compact model format #25

Zarxrax opened this issue Jul 25, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Zarxrax
Copy link

Zarxrax commented Jul 25, 2022

Using real-esrgan to train a model using the compact architecture results in a .pth model file that loads perfectly fine into VSGAN.
There is an application called chaiNNer which can be used to work with and manipulate models. If I save the model in chaiNNer, it outputs a model which no longer works in VSGAN.
One of the developers on chaiNNer said that real-esrgan creates its models with a lot of unnecessary information in the file that they strip out in order to be more in line with other types of models.

Would it be possible to add support for models in the format output by chaiNNer?
I have attached a model that was output directly from real-esrgan and then a version that was saved through chaiNNer
Models.zip
.

@joeyballentine
Copy link
Contributor

For reference @rlaphoenix, I added a simple extra condition to check for these kinds of models https://github.com/joeyballentine/chaiNNer/blob/2ced4094f201b4a7f6169fe36f498520f1784b5e/backend/src/nodes/pytorch_nodes.py#L41

Though I'm probably going to just make chaiNNer start saving these in their original format just for compatibility reasons, I didn't care about it previously because it was stupid how these were being saved officially (which I know you know since you also move the state out of the params key), but it does break compatibility with other stuff when saved.

@rlaphoenix
Copy link
Owner

This is likely to be similar to this later issue which is now closed: #35

Could you try with the latest master and see if it works for you?

@rlaphoenix rlaphoenix added the bug Something isn't working label May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants