Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions fail for no CRAN package (MODIStsp) #111

Open
oggioniale opened this issue Jan 9, 2024 · 4 comments
Open

Actions fail for no CRAN package (MODIStsp) #111

oggioniale opened this issue Jan 9, 2024 · 4 comments

Comments

@oggioniale
Copy link
Collaborator

@maelle @micha-silver
I solved most of the problems in the packages and a new version of this is deployed in the DEV branch.
The test-coverage (https://github.com/ropensci/ReLTER/actions/runs/7460327719/job/20298178183) fails because the dependency ‘MODIStsp’ is not available for package ‘ReLTER’.
I try to solve this by installing the MODISTSP package from remote

- name: Install remotes
        run: |
          Rscript -e "install.packages('remotes', repos='https://ftp.belnet.be/mirror/CRAN')"

      - name: Install MODIStsp
        run: |
          Rscript -e "remotes::install_url('https://cran.r-project.org/src/contrib/Archive/MODIStsp/MODIStsp_2.1.0.tar.gz')"

because from 2023-12-29 the package is not included in the CRAN (https://cran.r-project.org/web/packages/MODIStsp/index.html).

Any ideas?

@maelle
Copy link
Member

maelle commented Jan 9, 2024

MODIStsp is a package that needs a new maintainer, actually.

So I guess that's why the former maintainer requested archival on CRAN.

@ptagliolato
Copy link
Collaborator

Thanks Maelle. Is there any good practice in rOpenSci to manage this kind of issue? I read about the possibility to move a non-CRAN package to a different section of the DESCRIPTION file, namely from "Imports:" to "Remotes:" (see https://remotes.r-lib.org/articles/dependencies.html, https://stackoverflow.com/questions/30493388/create-an-r-package-that-depends-on-another-r-package-located-on-github). In our case, to continue using https://github.com/ropensci/MODIStsp, we should add to DESCRIPTION:

Remotes: ropensci/MODIStsp

This could hopefully solve the issue from a technical point of view (passing the issue encountered during the github action and for users willing to install ReLTER), but the point is then if it is an admitted practice within rOpenSci to "import" an rOpenSci package which is not a CRAN one.
Any suggestion welcome!

@maelle
Copy link
Member

maelle commented Jan 9, 2024

It is admitted, but you won't be able to submit the package to CRAN as is.
Do you know of anyone who might be willing to become MODIStsp's new maintainer?

@oggioniale
Copy link
Collaborator Author

Unfortunately we can't recommend anyone as a new maintainer

ptagliolato added a commit to ptagliolato/ReLTER that referenced this issue Jan 10, 2024
ptagliolato added a commit that referenced this issue Jan 10, 2024
Fixing imports for package no more in CRAN. See #111
oggioniale added a commit that referenced this issue Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants