Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpclient retry: add test(s) using webmockr then #137

Open
maelle opened this issue Apr 9, 2020 · 4 comments · May be fixed by #167
Open

httpclient retry: add test(s) using webmockr then #137

maelle opened this issue Apr 9, 2020 · 4 comments · May be fixed by #167
Assignees
@maelle

Comments

@maelle
Copy link
Member

maelle commented Apr 9, 2020

Would it be ok if I tried doing that?
@sckott
Copy link
Collaborator

sckott commented Apr 9, 2020

Yes, thanks

@maelle
Copy link
Member Author

maelle commented Apr 9, 2020

cool, will do this or next week hopefully 😀

@maelle maelle self-assigned this Apr 9, 2020
@sckott
Copy link
Collaborator

sckott commented Jan 22, 2022

still want to do this @maelle ?

@maelle maelle linked a pull request Jan 27, 2022 that will close this issue
Draft
@maelle
Copy link
Member Author

maelle commented Jan 27, 2022

Oops sorry for the massive delay. Yes I'd still be keen to learn how to do this and opened a very lame PR. I'd understand if it's easier for you to close it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maelle maelle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

try adding test ropensci/crul
2 participants
@sckott @maelle