Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate progress bars for Async requests #168

Open
sxthimons opened this issue Mar 15, 2022 · 3 comments
Open

Integrate progress bars for Async requests #168

sxthimons opened this issue Mar 15, 2022 · 3 comments

Comments

@sxthimons
Copy link

Currently, it looks like Async does not allow for the progress to be displayed when making requests. This would be helpful to determine if a request is still in progress or failing.

@sckott
Copy link
Collaborator

sckott commented Mar 15, 2022

You can pass httr::progress() to the progress param in https://docs.ropensci.org/crul/reference/HttpRequest.html which are used in https://docs.ropensci.org/crul/reference/AsyncVaried.html

But I doubt that's what you are looking for. I assume you are looking for progress across all the requests rather than within each request?

@sxthimons
Copy link
Author

I'd prefer across each request. When using the Async$new(urls = urls, progress = httr::progress()) it doesn't look like it's accepting it trying to create the initial R6 class variable:
Error in initialize(...) : unused argument (progress = list(NULL, NULL, NULL, NULL, list(FALSE, function (down, up)...

I've also tried to pass it through the opts argument on the Async as well.

@sckott
Copy link
Collaborator

sckott commented May 19, 2022

I don't think this will happen unless you want to add it yourself via a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants