-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the blocked texts on the menu page after adding an event class #22
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you wanted was to have a larger font because of poor eyesight. What you've changed is to make CalendarTrigger override your (or any other user's) choice of font size so that you can see all the text in the buttons, but you don't get the large font that you wanted. Also you get different font sizes in different buttons, which to me looks untidy.
I think that I would prefer to make the menu scrollable so that if the you pick a large font you get it, but you have to scroll to see the whole menu. What do you think of that as a solution? I'll have a think myself about that and see if it can be done easily. I think it's just a matter of embedding the buttons in a scrolling window, which I do in some other screens which have a lot of buttons in them.
However some of those other screens would probably not behave well with a large font because they have long lines. Making all the lines short wastes a lot of screen space for users who aren't using a large font. I don't think that layout xml can handle changing layout according to font size: this would have to be done by code.
An alternative solution for you without changing the code at all might be to do a long press on a button: this will show a toast with a description of what that button does, which I think will come up in your preferred font size, and it can fill the whole screen if it needs to do so.
Thanks for you comment! The reason why I set those font size to ‘autosizetexttype’ is because I think it’s pivotal to see all of the texts inside those buttons. Though those texts will be smaller, I still could see all of the texts instead of being blocked. I guess this is a solution, but adjust the height of those button is another way to do this. |
Hi! I just spotted that after I click the fifth button, the "event end definition for class XXX" button, the popup setting page is not scrollable when the largest font and display are applied. And I tried to fix that issue. Here is the screenshot after my fix. Thanks again for your patience and kindness! I am looking forward to your comments! :) |
Dear developer:
Hello! I am the creator of issue #21, and I have fixed the blocked texts on the menu page after adding an event class. I would appreciate it if you could kindly revise my code and leave me some advice. Thank you so much for your precious time!
Here is the screenshot after my changes:
Thanks again! Have a nice day! :)