Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically pop new tab for external links #139

Open
ilanolkies opened this issue Feb 5, 2020 · 3 comments
Open

Automatically pop new tab for external links #139

ilanolkies opened this issue Feb 5, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ilanolkies
Copy link
Contributor

ilanolkies commented Feb 5, 2020 •
edited
Loading

What

  • Current behavior: external links must be redirected to new tab manually
  • Desired behavior: all external links should automatically redirect to new tab

Why

  • Most external links appear on steps. If the user clicks external link on a step, he/she looses the current page.
@ilanolkies ilanolkies added the enhancement New feature or request label Feb 5, 2020
This was referenced Feb 6, 2020
Merged
Merged
@alebanzas
Copy link
Contributor

@ilanolkies @bguiz can we consider this issue solved?

@ilanolkies
Copy link
Contributor Author

ilanolkies commented Apr 17, 2020 •
edited
Loading

Nop. For example https://developers.rsk.co/rif/rns/operations/register/ does not pop a new window automatically. (RNS Manager link)

@ilanolkies
Copy link
Contributor Author

If this cannot be solved programmatically I propose another solution:

  1. Update all external urls with a bot
  2. Add a test requiring all external links in a PR are on new tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alebanzas @ilanolkies