Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID: '���' (FFFBB0) not supported! #25

Open
zloss opened this issue Sep 7, 2022 · 2 comments
Open

ID: '���' (FFFBB0) not supported! #25

zloss opened this issue Sep 7, 2022 · 2 comments
Assignees
Labels
improvement Making things better (more stable/readable) possible bug This might be a bug. question Further information is requested

Comments

@zloss
Copy link

zloss commented Sep 7, 2022

$ id3edit --readonly --showheader --get-all --get-frames invalid.mp3
Header
ID: '���'
Version: 2.0.0
Flags: 0x00
Size: 0
ID: '���' (FFFBB0) not supported!
ID3V2_Open failed with error -2!

$ hexdump -C invalid.mp3 | head -n 30
00000000 ff fb b0 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
00000010 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
00000020 00 00 00 00 49 6e 66 6f 00 00 00 0f 00 00 14 0d |....Info........|
00000030 00 31 1d 0e 00 03 05 08 0a 0d 10 12 14 17 1a 1c |.1..............|
00000040 1f 21 23 27 29 2b 2e 30 33 36 38 3b 3d 40 43 45 |.!#')+.0368;=@ce|
00000050 47 4a 4d 4f 52 54 57 5a 5c 5e 61 63 66 69 6b 6e |GJMORTWZ^acfikn|
00000060 70 73 76 78 7a 7d 80 82 85 87 8a 8d 8f 92 94 96 |psvxz}..........|
00000070 9a 9c 9e a1 a3 a6 a9 ab ad b0 b3 b5 b8 ba bd c0 |................|
00000080 c2 c5 c7 c9 cd cf d1 d4 d6 d9 dc de e1 e3 e6 e9 |................|
00000090 eb ed f0 f3 f5 f8 fa fc 00 00 00 00 4c 61 76 66 |............Lavf|
000000a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
000000b0 00 24 00 00 00 00 00 00 00 31 1d 0e 4a e4 3d e6 |.$.......1..J.=.|
000000c0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
00000270 00 00 ff fb b0 64 00 0c e4 c5 76 9c 91 06 4d f2 |.....d....v...M.|
00000280 4c 47 73 e0 04 22 8e 0c a1 a4 8e 60 8c de c1 ee |LGs..".........| 00000290 39 10 84 33 0d a1 00 04 63 1e fb 44 41 a0 b0 77 |9..3....c..DA..w| 000002a0 09 37 2f ef 7b d9 09 02 82 88 94 ef 6e c4 23 db |.7/.{.......n.#.| 000002b0 10 20 9c 63 de b4 78 fd ed 88 4a 71 04 08 16 4f |. .c..x...Jq...O| 000002c0 58 c4 d8 86 5d de e3 65 dd eb 3d c0 21 0f cf 59 |X...]..e..=.!..Y| 000002d0 00 82 64 f6 23 18 10 20 98 5d 41 81 04 10 8d 7b |..d.#.. .]A....{| 000002e0 d8 7d 88 dc 82 19 da 23 62 33 c7 31 0b 3d 36 87 |.}.....#b3.1.=6.| 000002f0 bb e4 c9 ee 1e 4e ca 20 4c 9e b9 34 ef 60 56 f8 |.....N. L..4.V.|
00000300 75 05 06 20 a3 6a 12 31 02 04 08 10 0a c0 38 1b |u.. .j.1......8.|
00000310 0d b4 40 48 c2 02 7a bd 86 23 46 dd ae de ce 7e |..@h..z..#F....~|
00000320 19 e7 35 18 5d bf fd cf ff eb f5 d1 96 64 7f e3 |..5.]........d..|
00000330 7e 70 60 1e 40 05 90 c6 c0 a0 46 05 c6 36 43 83 |~p`[email protected].|
00000340 8c 7e 63 77 37 8d 90 20 f9 79 03 31 be 63 63 1f |.~cw7.. .y.1.cc.|
00000350 92 42 7f 3b a1 00 df 07 c3 ca 0c 44 00 fc 4f 97 |.B.;.......D..O.|
00000360 3f 65 85 0b 9f 89 e4 c3 0a 70 80 a7 ca 4a 14 a8 |?e.......p...J..|

@rstemmer
Copy link
Owner

rstemmer commented Sep 7, 2022

The mp3 file you are trying to edit does not have an ID3Tag:
Wikipedia: FF FB-> "MPEG-1 Layer 3 file without an ID3 tag or with an ID3v1 tag (which is appended at the end of the file)"

This case is already covered in the code at this line
Anyway you still need to explicit use the --create command line option to create a new Tag.

Can you give a bit more context?
What did you expect to happen?
Did you expect the file already has an ID3Tag?

Anyway I will improve the output of id3edit for this scenario so that it is more clear for the user what to do.

Thank you for reporting the bug.

@rstemmer rstemmer added question Further information is requested improvement Making things better (more stable/readable) possible bug This might be a bug. labels Sep 7, 2022
@rstemmer rstemmer self-assigned this Sep 7, 2022
@rstemmer
Copy link
Owner

Looks a bit like #20
Detection of missing ID3 header needs to be improved - well, handled in a better way than it is done now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Making things better (more stable/readable) possible bug This might be a bug. question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants