Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for rust-src in build.rs #3

Open
parasyte opened this issue Jun 23, 2019 · 1 comment
Open

Check for rust-src in build.rs #3

parasyte opened this issue Jun 23, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects

Comments

@parasyte
Copy link
Collaborator

parasyte commented Jun 23, 2019

cargo-xbuild is a dependency for building the MIPS sysroot, and core, alloc, and compiler-builtins crates. rust-src is a dependency of cargo-xbuild.

These dependencies should be checked in build.rs and error out with a clear list of what's missing and how to install it.

@parasyte parasyte added this to To do in v0.2.0 Jun 23, 2019
@Lokathor
Copy link
Member

I wouldn't appreciate a build.rs file installing programs without a specific off-by-default feature being enabled for that build.

Instead, consider having the build.rs check for any dependencies and error out with a clear list of what's missing and how to install it.

@parasyte parasyte changed the title Check/install cargo-xbuild in build.rs Check for cargo-xbuild in build.rs Jun 23, 2019
@parasyte parasyte changed the title Check for cargo-xbuild in build.rs Check for cargo-xbuild and rust-src in build.rs Jun 23, 2019
@parasyte parasyte added enhancement New feature or request good first issue Good for newcomers labels Oct 27, 2019
@parasyte parasyte changed the title Check for cargo-xbuild and rust-src in build.rs Check for rust-src in build.rs May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
v0.2.0
  
To do
Development

No branches or pull requests

2 participants