OOP school library: refactor your code

[sadaf-Daneshgar]

New Features 🥇

• 🔰 Create the refactor.rb, clean the main.rb file.
• 🔰 Make sure YAGNI, KISS, and DRY rules and Ruby style guide are respected.
• 🔰 Follow SOLID principles.
• 🔰 Make sure that the role of main.rb is only to start your code and ask the user for the initial choice of options (or to quit).

👥 Authors

@sadaf-Daneshgar
@MohammadYaser

[codepantha]

STATUS: CHANGES REQUIRED ♻️

Hi team 👋,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights 🎯

✔️ Descriptive PR
✔️ Good commit history
✔️ No linter errors

Required Changes ♻️

Check the comments under the review.

• The following methods in your app.rb file do not follow the single responsibility, YAGNI, and KISS rules. Please note that all requests for input and input validation should be placed in the main.rb file or in classes/methods whose responsibilities are to request or validate input.
  The methods you should refactor are:
• create_book, create_person, create_teacher, create_student and create_rental

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

• nil

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[V-Blaze]

Hi @sadaf-Daneshgar, @MohammadYaser

Approved 🟢 🟢

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Highlights

• Code follows YAGNI, KISS, and DRY principles💯
• App works as expected👍
• Correct git flow🟢 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.