OOP school library: unit tests #8
Conversation
There was a problem hiding this comment.
Hi @sadaf-Daneshgar,
STATUS: CHANGES REQUIRED ♻️ ♻️
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- All linter checks are passing ✔️ ✔️
- Your PR is professional 👍 👍
- You did well testing all classes and decorators 👍 👍
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| it 'adds rental' do | ||
| book = double('book') | ||
| expect(Rental).to receive(:new).with(any_args).and_return(double('rental')) | ||
| person.add_rental('2023-01-01', book) | ||
| end |
There was a problem hiding this comment.
- You have done well so far, please complete this test after calling the
add_bookmethod to ensure that the rentals array contains the rental added. Please fix this 🙏
spec/trimmer_decorator_spec.rb
Outdated
| require 'rspec' | ||
| require_relative '../trimmer_decorator' | ||
|
|
||
| class TestNameable < Nameable | ||
| def correct_name | ||
| 'Ali' | ||
| end | ||
| end | ||
|
|
||
| describe Decorator do | ||
| let(:nameable_instance) { TestNameable.new } | ||
| let(:decorator_instance) { Decorator.new(nameable_instance) } | ||
|
|
||
| it 'raises NotImplementedError for correct_name when called on the base class' do | ||
| expect do | ||
| Nameable.new.correct_name | ||
| end.to raise_error(NotImplementedError, 'Subclasses must implement the correct_name method.') | ||
| end | ||
|
|
||
| it 'returns the correct name using the decorator' do | ||
| expect(decorator_instance.correct_name).to eq('Ali') | ||
| end | ||
|
|
||
| it 'updates the nameable attribute' do | ||
| new_nameable_instance = TestNameable.new | ||
| decorator_instance.nameable = new_nameable_instance | ||
| expect(decorator_instance.correct_name).to eq('Ali') |
There was a problem hiding this comment.
- You have done well so far, but please write tests to show that your trimmer decorator works as expected and gets the first 10 letters of the name when the name has more than 10 characters. Please fix this 👍 👍
There was a problem hiding this comment.
APPROVED 🟢 ✔️
Hi team👋,
Great job implementing the required changes 👏
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights 🎯
✔️ Descriptive PR
✔️ All tests are passing ✔️
✔️ No linter errors 🟢
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
New Features
BookPersonStudentTeacherClassroomRental👥 Authors
@sadaf-Daneshgar
@MohammadYaser