Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDD project #9

Merged
merged 7 commits into from
Nov 17, 2023
Merged

TDD project #9

merged 7 commits into from
Nov 17, 2023

Conversation

sadaf-Daneshgar
Copy link
Owner

@sadaf-Daneshgar sadaf-Daneshgar commented Nov 15, 2023

New Features

  • ✅ Create a class called Solver.
  • ✅ Create a method called factorial that takes one argument, an integer N, and returns the factorial for that number. The factorial is the multiplication of all integers from 1 to N and has the special case that the factorial of 0 is 1. This method only accepts 0 and positive integers, so if a negative integer is given it should raise an exception.
  • ✅ Create a method called reverse that takes one argument, a string word, and returns word reversed (e.g. if word is "hello" it returns "olleh").
  • ✅ Create a method called fizzbuzz that takes one argument, an integer N, and returns a string. The returned string is constructed following these rules:
    • When N is divisible by 3, return "fizz".
    • When N is divisible by 5, return "buzz".
    • When N is divisible by 3 and 5, return "fizzbuzz".
    • Any other case, return N as a string (e.g. say N is 7 then return "7").

👥 Authors

@sadaf-Daneshgar
@MohammadYaser

Copy link

@Qoosim Qoosim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 🎉 ✔️

Hi @team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Implemented project requirements. ✔️
  • No linter errors. ✔️
  • Good README file. ✔️
  • Correct Gitflow. ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@MohammadYaser MohammadYaser merged commit 533fd95 into development Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants