Merge pull request #347 from saloonphp/feature/throw-an-exception-whe…

…n-missing-method

Feature | Throw an exception when missing HTTP method

src/Http/Request.php

@@ -4,6 +4,7 @@
 
 namespace Saloon\Http;
 
+use LogicException;
 use Saloon\Enums\Method;
 use Saloon\Traits\Bootable;
 use Saloon\Traits\Makeable;
@@ -43,6 +44,10 @@ abstract class Request
      */
     public function getMethod(): Method
     {
+        if (! isset($this->method)) {
+            throw new LogicException('Your request is missing a HTTP method. You must add a method property like [protected Method $method = Method::GET]');
+        }
+
         return $this->method;
     }
 

tests/Fixtures/Requests/MissingMethodRequest.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Saloon\Tests\Fixtures\Requests;
+
+use Saloon\Http\Request;
+
+class MissingMethodRequest extends Request
+{
+    /**
+     * Define the endpoint for the request.
+     */
+    public function resolveEndpoint(): string
+    {
+        return '/user';
+    }
+}

tests/Unit/RequestTest.php

@@ -11,6 +11,7 @@
 use Saloon\Tests\Fixtures\Responses\CustomResponse;
 use Saloon\Exceptions\InvalidResponseClassException;
 use Saloon\Tests\Fixtures\Requests\InvalidResponseClass;
+use Saloon\Tests\Fixtures\Requests\MissingMethodRequest;
 use Saloon\Tests\Fixtures\Requests\CustomEndpointRequest;
 use Saloon\Tests\Fixtures\Requests\DefaultEndpointRequest;
 use Saloon\Tests\Fixtures\Connectors\CustomBaseUrlConnector;
@@ -117,3 +118,10 @@
     ['', 'google.com/search', '/google.com/search'],
     ['https://google.com', 'https://api.google.com/search', 'https://api.google.com/search'],
 ]);
+
+test('it throws an exception if you forget to add a method', function () {
+    $connector = new TestConnector;
+    $request = new MissingMethodRequest;
+
+    $connector->send($request);
+})->throws(LogicException::class, 'Your request is missing a HTTP method. You must add a method property like [protected Method $method = Method::GET]');