Excessive memory consumption

[EmilianoCostantini]

Just enabling the addon will make the browser's memory consumption skyrocket from ~0.6 to ~2.5Gb, almost causing the browser itself to freeze, along with the whole system. Meanwhile, a small number on a light blue background will appear over the addon icon, constantly changing in value.

What does such number represent?

Tested on:

• Mozilla Firefox 60.7.2esr (64 bit)
• Buku 3.7
• BukuBrow-WebApp 5.0.0.2
• BukuBrow-Host 5.0.0
• GNU/Linux Ubuntu 18.04.2 (bionic)
• Kernel 4.18.0-25-generic
• number of bookmarks successfully imported into Buku db: ≥6500, some of which very large.

[samhh]

The badge number represents the number of bookmarks which match the URL or domain of your active tab.

• Is this a recent regression?
• If you disable the badge in the extension settings do you see improved behaviour?
• Is that memory jump immediate, or is it continuously increasing each time you do anything that causes the badge number to change?

[EmilianoCostantini]

1. I couldn't tell, I never managed to get the addon up and running before.

2. Selecting No badge neatly improves performances: while the memory jumps are still there (especially while switching tabs) they are less severe and tend to decrease quickly enough, allowing the browser to remain usable. Actually I couldn't even tell if they are related to the addon.
   Selecting Badge without count, on the other hand, does not make significant differences with respect to Badge with count: the browser still gets jammed, along with the whole OS.

3. I've run several tests, restarting Firefox and/or the OS, but I don't really seem to be able to get a consistent behaviour.
   Most of the times just selecting Badge with count from preferences will trigger the memory jump in less than 2 seconds; the spike will get worse when switching tab, and slowly decrease if the browser is left untouched for more than 30 seconds.
   The only detected constant is that Badge with count will ineluctably make the browser unusable.

I'll keep running tests, and post if I find something.

In case it may be useful, I managed to take a screenshot of the about:memory page while Badge with count was selected (see attachment).