Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLACKLIGHT_VERSION not used by travis #439

Open
cjcolvar opened this issue Apr 6, 2018 · 1 comment
Open

BLACKLIGHT_VERSION not used by travis #439

cjcolvar opened this issue Apr 6, 2018 · 1 comment
Milestone
11.0.0

Comments

@cjcolvar
Copy link
Member

cjcolvar commented Apr 6, 2018

Descriptive summary

The BLACKLIGHT_VERSION environment variable isn't being respected by travis in the bundle install.

Rationale

The BLACKLIGHT_VERSION environment variable allows us to test with a specific version of blacklight to ensure compatibility with specific versions especially older versions.

Expected behavior

Travis bundle installs the version of blacklight specified by BLACKLIGHT_VERSION.

Actual behavior

Travis bundle installs the latest blacklight version that matches the gemspec restrictions.
@cjcolvar cjcolvar mentioned this issue Apr 6, 2018
Merged
@jcoyne
Copy link
Member

jcoyne commented Apr 6, 2018 •
edited
Loading

We used to have 5991392#diff-93cb22574ece26fa7717ab22d8332c69R6, and I think that was removed in 5944ba5

@cjcolvar cjcolvar added this to the 11.0.0 milestone Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0.0
Development

No branches or pull requests
2 participants
@jcoyne @cjcolvar