Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark and Light UI Transition | Improvement #48

Open
pooja-gera opened this issue Oct 2, 2021 · 10 comments
Open

Dark and Light UI Transition | Improvement #48

pooja-gera opened this issue Oct 2, 2021 · 10 comments
Assignees

Comments

@pooja-gera
Copy link
Contributor

Greetings!

When we transition from the light to the dark mode or vice-versa, the transition is not smooth.

Suggested Improvements:

  1. We can add a smooth transition which makes the look and feel of the application better.
  2. In the light mode, the switch has a circular icon, and in the dark mode, the switch has a moon icon. We can either add circles for both light and dark mode or add sun and a moon to maintain uniformity.

Do suggest any changes or further improvements.
It'll be super if I could be assigned this issue.

Thanks and regards,
Pooja Gera

@samz5320
Copy link
Owner

samz5320 commented Oct 2, 2021

Do you mind waiting for a bit pls? cause the author of the previous merge on this issue hasn't completed his code yet. He still has to make some minor changes. Once he's finished ill assign it to you. Then you can view the changes and discuss them?

@h2o-Noob
Copy link

h2o-Noob commented Oct 2, 2021

I can work on this issue, i have previously done added dark themes and transitions of themes to my practice websites. please assign me this issue

@ShivVIT2019
Copy link

Can You Please Assign to me??????

@samz5320
Copy link
Owner

samz5320 commented Oct 6, 2021

@pooja-gera go ahead pls. try not to do major changes. attach screenshot with ur PR.

@pooja-gera
Copy link
Contributor Author

Sure thank-you! @samz5320

@pooja-gera
Copy link
Contributor Author

Hey @samz5320 I just noticed the toggle switch has been updated on the website, should I update the toggle switch too? Or should I just make the transition between the two color themes smoother?

@samz5320
Copy link
Owner

samz5320 commented Oct 6, 2021

Smoother for now.

@pooja-gera
Copy link
Contributor Author

Okay, got it! ^.^

@pooja-gera
Copy link
Contributor Author

Hello I am done with this feature.

Here is how the toggle transition looked before:
currentToggleState

Here is what I have updated:
updatedToggleState

Explanation: The transition between the light and the dark colors has been synced with the transition of the toggle switch. When the toggle switch is moving towards the dark mode, giving an effect that nightfall is coming over the application and similarly when the toggle switch is moving towards the light mode, an effect that daylight is coming over the application is given.

Please let me know if everything looks okay or if any other changes are required. I'll submit a PR then ^.^

@samz5320
Copy link
Owner

Looks gud! Submit ur PR .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants