UPD: Migration for MapieRegressor #305
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 32 +5
Lines 3475 3523 +48
Branches 360 364 +4
=========================================
+ Hits 3475 3523 +48
☔ View full report in Codecov by Sentry. |
thibaultcordier
changed the title
| ) == y`` | ||
| It should be specified if ``consistency_check==True``. | ||
|
|
||
| By default ``np.float64(1e-8)``. |
There was a problem hiding this comment.
I know that we use this as an eps in other classes in MAPIE.
from ._machine_precision import EPSILON
I think we should keep this uniform.
| self, | ||
| sym: bool, | ||
| consistency_check: bool = True, | ||
| eps: np.float64 = np.float64(1e-8), |
There was a problem hiding this comment.
Same logic for epsilon.
| ) -> NDArray: | ||
| """ | ||
| Placeholder for ``get_signed_conformity_scores``. | ||
| Subclasses should implement this method! |
There was a problem hiding this comment.
Not sure if we want to use exclamation marks. Seems a bit overdone ;)
|
|
||
| Parameters | ||
| ---------- | ||
| y: NDArray |
There was a problem hiding this comment.
I think this might be recurrent, but in the parameters, you call this an NDArray but it's an ArrayLike. Also you are not give the shape of these arrays.
| "are not consistent. " | ||
| "The following equation must be verified: " | ||
| "self.get_estimation_distribution(y_pred, " | ||
| "self.get_conformity_scores(y, y_pred)) == y. " # noqa: E501 |
There was a problem hiding this comment.
What is this # noqa: E501?
| def _check_predicted_data( | ||
| self, | ||
| y_pred: ArrayLike, | ||
| ) -> None: |
| def _all_strictly_positive( | ||
| self, | ||
| y: ArrayLike, | ||
| ) -> bool: |
| @@ -0,0 +1,343 @@ | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
Difficult to see with the github diff, but have you changed any of the code from the previous code to this one?
| @@ -0,0 +1,709 @@ | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
Difficult to see with the github diff, but have you changed any of the code from the previous code to this one?
|
|
||
| y_pred_1, y_pis_1 = mapie_c1.predict(X, alpha=0.1) | ||
| y_pred_2, y_pis_2 = mapie_c2.predict(X, alpha=0.1) | ||
| np.testing.assert_allclose(y_pis_1[:, 0, 0], y_pis_2[:, 0, 0]) |
There was a problem hiding this comment.
Why are we using np.testing.assert_allclose and not np.testing. assert_array_equal?
thibaultcordier
deleted the
300-premise-adaptative-conformal-prediction
branch
Description
Propose a migration of some methods / classes / modules.
Type of change
Checklist
make lintmake type-checkmake testsmake coveragemake doc