Enable SMP on qemu-arm-virt #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybui01
force-pushed
the
andyb/qemu-smp
branch
from
40d1c05
to
d84d82b
Compare
We always use the EL2 qemu implementation, this allows the elfloader to boot secondary cores using SMC (the only method it supports). Note this is fine even if CONFIG_ARM_HYPERVISOR_SUPPORT is not set as the elfloader will drop from EL2 to EL1 before entering the seL4 kernel. We also set the -smp flag to KernelMaxNumNodes, to launch the necessary CPUs. Signed-off-by: Andy Bui <[email protected]>
andybui01
force-pushed
the
andyb/qemu-smp
branch
from
d84d82b
to
c5f182b
Compare
lsf37
reviewed
Jun 25, 2024
Comment on lines
-147
to
+150
| if(KernelArmHypervisorSupport) | ||
| if(Kernel32) | ||
| set(sim_machine "virt,virtualization=on,highmem=off,secure=off") | ||
| else() | ||
| set(sim_machine "virt") | ||
| set(sim_machine "virt,virtualization=on,highmem=on,secure=off") |
There was a problem hiding this comment.
Similar to the seL4 PR, I don't quite understand why would always switch on virtualisation. We do want to test simulated kernels on platforms that don't support virtualisation, so I don't think we should do that.
|
Feel free to re-open if adapting Elfloader doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: seL4/seL4#1275