Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close_old_findings and skip_duplicates should be configurable for Users #26

Open
rseedorff opened this issue Nov 25, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@rseedorff
Copy link
Member

rseedorff commented Nov 25, 2022

In the current implementation there are two configuration options hardcoded and not configurable for users. Would be great to make them configurable:

mvn.add("close_old_findings", "true");
mvn.add("skip_duplicates", "false");
mvn.add("test_type", String.valueOf(testType));

@rseedorff rseedorff added the enhancement New feature or request label Nov 25, 2022
@J12934
Copy link
Member

J12934 commented Nov 25, 2022

@rseedorff You should be able to overwrite these by setting the close_old_findings or skip_duplicates in the options MultiValueMap (the last param in the function).
The options map take precedent over these settings, they are merely the default values.

This is (like everything in the client) not documented :(

@rseedorff rseedorff added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Backlog
Development

No branches or pull requests

2 participants