Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOSS-Review] Paper Revisions #4

Open
HaoZeke opened this issue Dec 31, 2019 · 2 comments
Open

[JOSS-Review] Paper Revisions #4

HaoZeke opened this issue Dec 31, 2019 · 2 comments

Comments

@HaoZeke
Copy link

HaoZeke commented Dec 31, 2019

This is part of openjournals/joss-reviews#1843. Please address the following points:

  • The results should also be moved away from the git page and into the paper itself

Comparisons

image

  • This section should be re-written and the results must be included in the paper itself.
  • A graph would be better over time
  • Resource usage should be clarified

The code and github resources are good, but the write up needs to be more coherent and self-contained.
@shah314
Copy link
Owner

shah314 commented Jan 10, 2020

@HaoZeke I think I have made the changes you requested. Please review the updated paper. I have included the ColPack comparison table in the paper. I have also included the run times for ColPack and JCOL in the paper. Thank you for the review.

@shah314
Copy link
Owner

shah314 commented Jan 10, 2020

@jedbrown Please review the modified paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shah314 @HaoZeke