Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project Statistics] dayjs locale console warning #3115

Open
imnasnainaec opened this issue May 3, 2024 · 1 comment
Open

[Project Statistics] dayjs locale console warning #3115

imnasnainaec opened this issue May 3, 2024 · 1 comment
Labels
bug Something isn't working frontend lowpriority This might not be worked on project

Comments

@imnasnainaec
Copy link
Collaborator

Describe the bug

Project Settings > Workshop Schedule tab

For browser languages with a country code, the first schedule button option (with "range of days"), throws a locale console warning.

To Reproduce

Steps to reproduce the behavior:

  1. Set web browser to a country-specific language (e.g., "en-US" or "en-GB")
  2. Open a project in The Combine of which you are the owner or an administrator
  3. Click the gear icon in the top bar to open Project Settings
  4. Click the Schedule (calendar icon) tab
  5. Observe the three icons under the "Workshop Schedule" section heading
  6. Open the web browser console
  7. Hover over the left icon (with 6 dots in the calendar) and see hover text about "range of days"
  8. Click this icon and see a warning appear in the console:

console.js:273 Your locale has not been found.
Either the locale key is not a supported one. Locales supported by dayjs are available here: https://github.com/iamkun/dayjs/tree/dev/src/locale
Or you forget to import the locale from 'dayjs/locale/{localeUsed}'
fallback on English locale

@imnasnainaec imnasnainaec added bug Something isn't working frontend project lowpriority This might not be worked on labels May 3, 2024
@imnasnainaec imnasnainaec added this to To do in Combine Kanban via automation May 3, 2024
@imnasnainaec imnasnainaec moved this from To do to Discuss in planning meeting in Combine Kanban May 3, 2024
@jasonleenaylor
Copy link
Contributor

This could be due to our wrapping, or case sensitivity or insufficient fallback logic in dayjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend lowpriority This might not be worked on project
Projects
No open projects
Combine Kanban
Discuss in planning meeting
Development

No branches or pull requests

2 participants