Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording on two different entries back-to-back is broken #3151

Closed
imnasnainaec opened this issue Jun 4, 2024 · 2 comments · Fixed by #3157
Closed

Recording on two different entries back-to-back is broken #3151

imnasnainaec opened this issue Jun 4, 2024 · 2 comments · Fixed by #3157
Assignees
Labels
audio bug Something isn't working goal: ReviewEntries Size: S Small sized issue

Comments

@imnasnainaec
Copy link
Collaborator

Describe the bug

In the Review Entries tool, if you record audio for one entry, then try to record on a different one without first clicking elsewhere, either a second glitch recording appears on the first or 400 error occurs, such as

400 https://thecombine.app/v1/projects/626163298f13d53c418181ff/words/665f68e5bb6b4afb1ea21f1d/audio/upload

This is probably an unintended consequence of #3077, which was tested in Data Entry, but clearly not enough in Review Entries.

To Reproduce

Steps to reproduce the behavior:

  1. Open a project with at least two words.
  2. Click on Data Cleanup > Review Entries
  3. Click-and-hold the record icon (red circle) for one row
  4. When you release, a new play icon (green triangle) should appear in that row
  5. Click-and-hold the record icon in a different row
  6. Observe bug
@imnasnainaec imnasnainaec added this to To do in Combine Kanban via automation Jun 4, 2024
@imnasnainaec imnasnainaec moved this from To do to Discuss in planning meeting in Combine Kanban Jun 4, 2024
@jmgrady
Copy link
Collaborator

jmgrady commented Jun 5, 2024

This looks like the same root cause as #1930.

See axios/axios#4406 for some possible solutions.

@imnasnainaec
Copy link
Collaborator Author

This looks like the same root cause as #1930.

See axios/axios#4406 for some possible solutions.

They can both result in a 400 error, but they look much different to me. This one doesn't prevent audio recording in general. Just the specific case of back to back recordings on different rows of Review Entries.

@imnasnainaec imnasnainaec added the Size: S Small sized issue label Jun 5, 2024
@imnasnainaec imnasnainaec self-assigned this Jun 5, 2024
@imnasnainaec imnasnainaec changed the title Recording on two different entries back to back is broken Recording on two different entries back-to-back is broken Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio bug Something isn't working goal: ReviewEntries Size: S Small sized issue
Projects
No open projects
Combine Kanban
Discuss in planning meeting
Development

Successfully merging a pull request may close this issue.

2 participants