Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make alignment pipeline fully compatible with eflomal #443

Open
isaac091 opened this issue Jul 5, 2024 · 0 comments · May be fixed by #455
Open

Make alignment pipeline fully compatible with eflomal #443

isaac091 opened this issue Jul 5, 2024 · 0 comments · May be fixed by #455
Assignees
Labels
bug Something isn't working pipeline 3: preprocess Issue related to preprocessing.

Comments

@isaac091
Copy link
Collaborator

isaac091 commented Jul 5, 2024

Eflomal works when directly using the align script, but when the nmt scripts do alignment, they call the add_alignment_scores function from alignment/utils.py, which errors out when you try to use eflomal. I think all we need is a few checks added to the compute_alignment_scores function to prevent it from calling methods that don't exist for certain aligners.

@isaac091 isaac091 self-assigned this Jul 11, 2024
@isaac091 isaac091 linked a pull request Jul 13, 2024 that will close this issue
@isaac091 isaac091 added bug Something isn't working pipeline 3: preprocess Issue related to preprocessing. labels Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pipeline 3: preprocess Issue related to preprocessing.
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

1 participant