Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for entries after previous search can cause most relevant results to not be shown #1752

Open
alex-larkin opened this issue May 17, 2023 · 3 comments
Labels
Alex priority (used by Alex) specifies issues which Alex determines to be high priority bug An existing problem with our app in production

Comments

@alex-larkin
Copy link

Two ways to reproduce:

  1. Open "Quechua Demo" in Language Forge

  2. Scroll down to the Bs

  3. Search "ama"

  4. Notice that Language Forge appears to filter results, but the results don't seem to be too relevant

  5. Scroll up to the top see the most relevant results.

  6. Open "Quechua Demo" in Language Forge

  7. Search "winchus" and open the entry

  8. On the left, clear the search query and search for "ama"

  9. Notice that Language Forge appears to filter results, but the results don't seem to be too relevant

  10. Scroll up to see the most relevant results.

Desired behavior:
When conducting a new search, LF should reset the scrolling position to the top, showing the most relevant results first.

@alex-larkin alex-larkin added bug An existing problem with our app in production Alex priority (used by Alex) specifies issues which Alex determines to be high priority labels May 17, 2023
@alex-larkin alex-larkin changed the title Searching for entries after previous search can cause most relevant results to be not shown Searching for entries after previous search can cause most relevant results to not be shown May 17, 2023
@alex-larkin
Copy link
Author

Previously when searching for an entry and opening it, when the search query was then cleared, the entry list on the left would jump to the beginning of the lexicon. I created an issue to ask that upon clearing the query, that the searched-for term would remain visible on the left, showing the entries immediately above and below it. I think @longrunningprocess implemented this, but I can't find the issue on GH. The work done there might be related. (@longrunningprocess, no worries if you can't comment on this in a while.)

@alex-larkin
Copy link
Author

I also understand if this issue is tabled until LFNext is launched.

@longrunningprocess
Copy link
Contributor

ok, thanks Alex. I'm not sure whether I did that or Rick but either way I think it's something the team will have to prioritize in the right effort going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Alex priority (used by Alex) specifies issues which Alex determines to be high priority bug An existing problem with our app in production
Projects
Development

No branches or pull requests

2 participants