Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-ldeflate is missing in Makefile after I executed ./configure #98

Open
darkcircle opened this issue Jun 15, 2023 · 0 comments
Open

-ldeflate is missing in Makefile after I executed ./configure #98

darkcircle opened this issue Jun 15, 2023 · 0 comments

Comments

@darkcircle
Copy link

darkcircle commented Jun 15, 2023

As we know, HTSlib source tree is also included during compilation process.
HTSlib source tree also needs to refer libdeflate, but configure does not create Makefile containing LIBS="-ldeflate blabla ..."
(refer Makefile line 243.)

so ... in line 33 to 35 of Makefile.am

## xxx_LDADD is some additional libraries besides $LIBS which could collect
## the libraries added by AC_CHECK_LIB
cellsnp_lite_LDADD = @HTSLIB_LIB@

would better to be modified as below,

## xxx_LDADD is some additional libraries besides $LIBS which could collect
## the libraries added by AC_CHECK_LIB
cellsnp_lite_LDADD = @HTSLIB_LIB@ -ldeflate

so I solved compilation problem by fixing the automake script as above.
How would you think about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant