Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint checks #149

Open
ZacSweers opened this issue Sep 29, 2022 · 0 comments
Open

Lint checks #149

ZacSweers opened this issue Sep 29, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@ZacSweers
Copy link
Collaborator

ZacSweers commented Sep 29, 2022

  • no compose UI in presenters
  • don't put navigators in state
  • no mutable state (can copy from our Moshi lints)
  • discourage android composition locals in presenter bodies
  • no non-stable property types in state classes
  • annotating assisted-injected classes with circuitinject (should be on the assisted factory)
  • non-injectable parameter injections in assisted classes or functions (i.e. only screen, modifier, and navigator are accepted)
  • annotating non-presenter/non-ui classes with circuitinject
  • Don't put overlays in mutablestate (i.e. def don't retain them)
  • screen classes should just be data object classes
  • screen objects should be data objects
  • sealed event object subtypes should be data objects
  • port ProduceStateDoesNotAssignValue from produceState (and other related ones)
  • ???
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant