tidy test 1 #11
tidy test 1 #11
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| static const std::map<e_model, size_t> & MEM_REQ_SCRATCH0() | ||
| { | ||
| static std::map<e_model, size_t> _MEM_REQ_SCRATCH0 = { |
There was a problem hiding this comment.
warning: declaration uses identifier '_MEM_REQ_SCRATCH0', which is a reserved identifier [bugprone-reserved-identifier]
| static std::map<e_model, size_t> _MEM_REQ_SCRATCH0 = { | |
| static std::map<e_model, size_t> MEM_REQ_SCRATCH0 = { |
llama-test.cpp:58:
- return _MEM_REQ_SCRATCH0;
+ return MEM_REQ_SCRATCH0;|
|
||
| static const std::map<e_model, size_t> & MEM_REQ_SCRATCH1() | ||
| { | ||
| static std::map<e_model, size_t> _MEM_REQ_SCRATCH1 = { |
There was a problem hiding this comment.
warning: declaration uses identifier '_MEM_REQ_SCRATCH1', which is a reserved identifier [bugprone-reserved-identifier]
| static std::map<e_model, size_t> _MEM_REQ_SCRATCH1 = { | |
| static std::map<e_model, size_t> MEM_REQ_SCRATCH1 = { |
llama-test.cpp:69:
- return _MEM_REQ_SCRATCH1;
+ return MEM_REQ_SCRATCH1;| // 2*n_embd*n_ctx*n_layer*sizeof(float16) | ||
| static const std::map<e_model, size_t> & MEM_REQ_KV_SELF() | ||
| { | ||
| static std::map<e_model, size_t> _MEM_REQ_KV_SELF = { |
There was a problem hiding this comment.
warning: declaration uses identifier '_MEM_REQ_KV_SELF', which is a reserved identifier [bugprone-reserved-identifier]
| static std::map<e_model, size_t> _MEM_REQ_KV_SELF = { | |
| static std::map<e_model, size_t> MEM_REQ_KV_SELF = { |
llama-test.cpp:81:
- return _MEM_REQ_KV_SELF;
+ return MEM_REQ_KV_SELF;| // not actually needed if BLAS is disabled | ||
| static const std::map<e_model, size_t> & MEM_REQ_EVAL() | ||
| { | ||
| static std::map<e_model, size_t> _MEM_REQ_EVAL = { |
There was a problem hiding this comment.
warning: declaration uses identifier '_MEM_REQ_EVAL', which is a reserved identifier [bugprone-reserved-identifier]
| static std::map<e_model, size_t> _MEM_REQ_EVAL = { | |
| static std::map<e_model, size_t> MEM_REQ_EVAL = { |
llama-test.cpp:94:
- return _MEM_REQ_EVAL;
+ return MEM_REQ_EVAL;| std::unique_ptr<llama_mmap> mapping; | ||
|
|
||
| llama_model_loader(const std::string & fname_base, bool use_mmap, bool vocab_only) { | ||
| auto first_file = new llama_file_loader(fname_base.c_str(), 0, tensors_map); |
There was a problem hiding this comment.
warning: 'auto first_file' can be declared as 'auto *first_file' [readability-qualified-auto]
| auto first_file = new llama_file_loader(fname_base.c_str(), 0, tensors_map); | |
| auto *first_file = new llama_file_loader(fname_base.c_str(), 0, tensors_map); |
| } | ||
| }; | ||
| if (int(workers.size()) < nthread_use - 1) workers.resize(nthread_use - 1); | ||
| for (int it = 0; it < nthread_use - 1; ++it) workers[it] = std::thread(compute); |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| for (int it = 0; it < nthread_use - 1; ++it) workers[it] = std::thread(compute); | |
| for (int it = 0; it < nthread_use - 1; ++it) { workers[it] = std::thread(compute); | |
| } |
| if (int(workers.size()) < nthread_use - 1) workers.resize(nthread_use - 1); | ||
| for (int it = 0; it < nthread_use - 1; ++it) workers[it] = std::thread(compute); | ||
| compute(); | ||
| for (int it = 0; it < nthread_use - 1; ++it) workers[it].join(); |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| for (int it = 0; it < nthread_use - 1; ++it) workers[it].join(); | |
| for (int it = 0; it < nthread_use - 1; ++it) { workers[it].join(); | |
| } |
| fprintf(stderr, "%s: loading base model from '%s'\n", __func__, path_base_model); | ||
| model_loader.reset(new llama_model_loader(path_base_model, /*use_mmap*/ true, /*vocab_only*/ false)); | ||
|
|
||
| size_t ctx_size, mmapped_size; |
There was a problem hiding this comment.
warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]
| size_t ctx_size, mmapped_size; | |
| size_t ctx_size; | |
| size_t mmapped_size; |
| } | ||
|
|
||
| std::string name(length, 0); | ||
| fin.read(&name[0], length); |
There was a problem hiding this comment.
warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
| fin.read(&name[0], length); | |
| fin.read(name.data(), length); |
| base_name.erase(pos); | ||
| // fprintf(stderr, "%s: %s => %s (lora type %s) ", __func__, name.c_str(),base_name.c_str(), lora_type.c_str()); | ||
|
|
||
| if (model_tensors.find(base_name.data()) == model_tensors.end()) { |
There was a problem hiding this comment.
warning: redundant call to 'data' [readability-redundant-string-cstr]
| if (model_tensors.find(base_name.data()) == model_tensors.end()) { | |
| if (model_tensors.find(base_name) == model_tensors.end()) { |
No description provided.