Remove RawEncoder (#52)

* Remove RawEncoder * Serialize relations into json and then decode them into associative array instead of using raw serialization
snagshout · May 19, 2023 · 97ff3e0 · 97ff3e0
1 parent d797844
commit 97ff3e0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 66 deletions.
diff --git a/php/src/Snagshout/Promote/Client.php b/php/src/Snagshout/Promote/Client.php
@@ -62,7 +62,6 @@ protected function buildResource(string $resourceClass): AbstractResource
             new Serializer(
                 NormalizerFactory::create(),
                 [
-                    new RawEncoder(),
                     new JsonEncoder(new JsonEncode(), new JsonDecode()),
                 ]
             )

diff --git a/php/src/Snagshout/Promote/Encoder/RawEncoder.php b/php/src/Snagshout/Promote/Encoder/RawEncoder.php
diff --git a/php/src/Snagshout/Promote/Normalizer/DealImpressionsRequestBodyNormalizer.php b/php/src/Snagshout/Promote/Normalizer/DealImpressionsRequestBodyNormalizer.php
@@ -41,7 +41,8 @@ public function normalize($object, $format = null, array $context = [])
         if (null !== $object->getImpressions()) {
             $values = [];
             foreach ($object->getImpressions() as $value) {
-                $values[] = $this->serializer->serialize($value, 'raw', $context);
+                $json = $this->serializer->serialize($value, 'json', $context);
+                $values[] = json_decode($json, true);
             }
             $data['impressions'] = $values;
         }

diff --git a/php/src/Snagshout/Promote/Normalizer/DealNormalizer.php b/php/src/Snagshout/Promote/Normalizer/DealNormalizer.php
@@ -220,14 +220,16 @@ public function normalize($object, $format = null, array $context = [])
         if (null !== $object->getCategories()) {
             $values = [];
             foreach ($object->getCategories() as $value) {
-                $values[] = $this->serializer->serialize($value, 'raw', $context);
+                $json = $this->serializer->serialize($value, 'json', $context);
+                $values[] = json_decode($json, true);
             }
             $data['categories'] = $values;
         }
         if (null !== $object->getMedia()) {
             $values_1 = [];
             foreach ($object->getMedia() as $value_1) {
-                $values_1[] = $this->serializer->serialize($value_1, 'raw', $context);
+                $json = $this->serializer->serialize($value_1, 'json', $context);
+                $values_1[] = json_decode($json, true);
             }
             $data['media'] = $values_1;
         }

diff --git a/php/tests/Snagshout/Promote/Normalizer/DealNormalizerTest.php b/php/tests/Snagshout/Promote/Normalizer/DealNormalizerTest.php
@@ -12,7 +12,6 @@
 namespace Tests\Snagshout\Promote\Normalizer;
 
 use PHPUnit\Framework\TestCase as BaseTestCase;
-use Snagshout\Promote\Encoder\RawEncoder;
 use Snagshout\Promote\Model\Category;
 use Snagshout\Promote\Model\Deal;
 use Snagshout\Promote\Model\Medium;
@@ -38,7 +37,6 @@ protected function getSerializer()
         return new Serializer(
             NormalizerFactory::create(),
             [
-                new RawEncoder(),
                 new JsonEncoder(
                     new JsonEncode(),
                     new JsonDecode()