Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Example2 Needs updated to issueset_addregated.all(), issueset.all() returns 404. #167

Open
1 task done
bmmcwhirt opened this issue Jan 23, 2023 · 1 comment
Open
1 task done
Labels
bug Something isn't working

Comments

@bmmcwhirt
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description of the bug

In the example2 (https://github.com/snyk-labs/pysnyk/blob/master/examples/api-demo-2-list-issues.py), it is still using the deprecated issueset.all() [api-demo-2-list-issues.py:60]. This example needs updated to use the new issueset_aggregated.all(). It looks like the old endpoint has been sunset as it now returns a 404.

The additional variables inside the returned object will be different so the print and excel [api-demo-2-list-issues.py:83-81] functions need updated as well.

If you don't get this updated, I can look into forking and rewriting that example and submit a pull request. I just don't know when I will have time.

Steps To Reproduce

Run https://github.com/snyk-labs/pysnyk/blob/master/examples/api-demo-2-list-issues.py

Additional Information

No response

@bmmcwhirt bmmcwhirt added the bug Something isn't working label Jan 23, 2023
@bmmcwhirt
Copy link
Author

Actually 2c is fine, though it's still prone to BUG 168.

Recommend renaming:
api-demo-2-list-issues.py -> deprecated_api-demo-2-list-issues.py
api-demo-2b-issues-analytics.py -> api-demo-2a-issues-analytics.py
api-demo-2c-list-issues-aggregated.py -> api-demo-2b-list-issues-aggregated.py

If some notation to api-demo-2-list-issues.py that the deprecated endpoint has now been sunset and can no longer be used this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant