Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosby V4 - AndroidX support #339

Open
sockeqwe opened this issue Dec 27, 2019 · 10 comments
Open

Mosby V4 - AndroidX support #339

sockeqwe opened this issue Dec 27, 2019 · 10 comments

Comments

@sockeqwe
Copy link
Owner

Unfortunately Mosby V3 is not compatable with AndroidX as accessing the backstack to see if a fragment is still in use (or presenter can be released) is not possible anymore in androidx as the method to get this information is "blacklisted" and no accessible from the outside anymore (it was in support.v4 days) see #338 #336

Any workaround suggested in #338 seems to me fragile.
Therefore I considering the following:
What we actually need is a lifecycle callback that tells us when the Fragment is actually destroyed. We could get this information by using AndroidX ViewModel,onCleared().

This will not be breaking change, rather it's a minor implementation detail under the hood.

What do you think?

@mseroczynski
Copy link
Contributor

mseroczynski commented Jan 10, 2020

For me it's "whatever works" as long as I can keep updating critically important dependencies, have you tried this approach? @sockeqwe Is there any v4 release ETA...?

@atetc
Copy link

atetc commented Jun 15, 2020

It would be fair if this important notice will appear in https://github.com/sockeqwe/mosby/blob/master/README.md

@HowardSchmaeu
Copy link

hi, is there any Progress in the AndroidX Development? It would nice to use your great lib also in AndroidX... also after Jake now has deprecated the ButterKnife...
Plz let us know what your plans are :-)

@sockeqwe
Copy link
Owner Author

sockeqwe commented Aug 9, 2020 via email

@HowardSchmaeu
Copy link

Hey nice to hear that you work on it. But bad news because of the deprecation :-(

@sockeqwe
Copy link
Owner Author

sockeqwe commented Aug 10, 2020 via email

@maestrovsmaster
Copy link

maestrovsmaster commented Aug 10, 2020

after update mosby to latest version, the method createPresenter called before onCreateView method of fragment, so i can not pass bundle parameters to presenter for creating initial state =(
Old order:

  1. first call onCreateView (and we can receive bundle params)
  2. second called override method createPresenter (we can pass initial params to presenter method initialModelSingle)

After mosby update

  1. first call method createPresenter (and we have not bundle initial params yet)
  2. second called override method createPresenter
    Why changed methods calling order?

@HowardSchmaeu
Copy link

Deprecation doesn't mean stop working not minor big fixes, just don't expect bigger releases > .

Okay great... but did you think you can create a new version of all without Butterknife? I thought this is deep chained in Mosby??

@DanielNovak
Copy link

Any news? Thank you.

@Evgeniy-Sh
Copy link

Hi! Tell me please the release date of Mosby v4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants