Skip to content
This repository has been archived by the owner on Aug 24, 2019. It is now read-only.

Pull progress > 1.0 is not reported. #51

Open
calebd opened this issue Nov 24, 2014 · 3 comments
Open

Pull progress > 1.0 is not reported. #51

calebd opened this issue Nov 24, 2014 · 3 comments

Comments

@calebd
Copy link
Contributor

calebd commented Nov 24, 2014

I see in 1.2.2, the call that clamped the scroll progress to < 1.0 is gone, but it still isn't being sent. In the KVO callback, the setProgress: call doesn't happen if the state is .Ready, which it is if the offset is greater than the expanded height. Not sure what the best solution is.

@soffes
Copy link
Owner

soffes commented Nov 24, 2014

Ah makes sense. Do you want to hack on it since you're using it? Should be an easy change.

@calebd
Copy link
Contributor Author

calebd commented Nov 24, 2014

Yeah I can build whatever is needed, I just want to make sure it falls within the spirit of the library if you know what I mean. As it is now, setProgress is only sent to content views when the state is .Normal. Do you think it's fine to send it any time the scroll view drags?

@soffes
Copy link
Owner

soffes commented Nov 24, 2014

Ya I think that's fine. If it's invalid for content views to get it when it's not normal, then can simply check and return in setProgress:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants