Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose max_buffered_{rx/tx}_bytes in the Tap filter #9656

Open
sadieleob opened this issue Jun 20, 2024 · 2 comments
Open

Expose max_buffered_{rx/tx}_bytes in the Tap filter #9656

sadieleob opened this issue Jun 20, 2024 · 2 comments
Labels

Comments

@sadieleob
Copy link

Gloo Edge Product

Enterprise

Gloo Edge Version

1.17

Is your feature request related to a problem? Please describe.

This is not related to an issue.

Describe the solution you'd like

The customer is asking to expose:

  • max_buffered_rx_bytes
  • max_buffered_tx_bytes
  • streaming
  • record_headers_received_time
  • record_downstream_connection

The customer stated that without the max_buffered_<rx/tx>_bytes fields set, the maximum body size is 1KiB that can be sent to the tap filter. Unfortunately, this max body size blocks our integration of the tap filter with their "in-house monetization" project since it requires payloads up to 4KB.

For the streaming field, this is not as important, but they would like to have this available in case buffering causes Envoy performance issues.

https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/tap/v3/common.proto#config-tap-v3-outputconfig
https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/tap/v3/tap.proto#extensions-filters-http-tap-v3-tap

Describe alternatives you've considered

There are no alternatives

Additional Context

No response

@sadieleob sadieleob added the Type: Enhancement New feature or request label Jun 20, 2024
@soloio-bot
Copy link

Zendesk ticket #3974 has been linked to this issue.

@nfuden
Copy link
Contributor

nfuden commented Jun 21, 2024

https://github.com/solo-io/solo-projects/issues/5455 encompasses this as well. @DuncanDoyle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants